chore: release 2.7.1

[Radi85]

No description provided.

[codecov-commenter]

Codecov Report

Merging #232 (31792ca) into develop (f8942bf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #232   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           55       55           
  Lines         1969     1969           
  Branches       158      158           
========================================
  Hits          1967     1967           
  Misses           1        1           
  Partials         1        1           

Impacted Files	Coverage Δ
comment/__init__.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8942bf...31792ca. Read the comment docs.

[abhiabhi94]

thanks for the patch.

[Radi85]

@abhiabhi94 Publish distribution 📦 to Test PyPI job was not triggered any idea?

[abhiabhi94]

@Radi85 was this a tagged commit? as of now, i can't see the tag on the branch staging although the build logs suggest that binaries were created to distribute, but the publishing task didn't execute. weird i guess 😕

[abhiabhi94]

one more thing, i merged the patch since i thought it to be a waste of time if it was approved by one of us, and just waited for merging. please let me know, if doesn't seem right.

[Radi85]

@Radi85 was this a tagged commit? as of now, i can't see the tag on the branch staging although the build logs suggest that binaries were created to distribute, but the publishing task didn't execute. weird i guess 😕

The job should be trigered after pushing staging branch and the tag is not required here! 🤔
BTW in the previous release the above was applied am not sure why it wasn't triggered here.

[Radi85]

one more thing, i merged the patch since i thought it to be a waste of time if it was approved by one of us, and just waited for merging. please let me know, if doesn't seem right.

I am not sure how the right process could be. However, I would prefer to handle the whole merging processe for the releases and don't mind when one of us merge the fueatures/bugfixes.

[abhiabhi94]

The job should be trigered after pushing staging branch and the tag is not required here! 🤔
BTW in the previous release the above was applied am not sure why it wasn't triggered here.

no, it should only be triggered on tags, see: https://github.com/Radi85/Comment/blob/develop/.github/workflows/release.yml#L31

[Radi85]

no, it should only be triggered on tags, see: https://github.com/Radi85/Comment/blob/develop/.github/workflows/release.yml#L31

Then let's remove the tag condition. I am not sure how did it work in the previous release without tag.