Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#224): Move validation of orders to system checks #235

Merged
merged 1 commit into from
Nov 4, 2021
Merged

feat(#224): Move validation of orders to system checks #235

merged 1 commit into from
Nov 4, 2021

Conversation

abhiabhi94
Copy link
Collaborator

No description provided.

@abhiabhi94
Copy link
Collaborator Author

i have moved the error messages from the messages module since this would most be used by developers and may not necessarily need translation.

Radi85
Radi85 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Owner

@Radi85 Radi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @abhiabhi94.
Thanks for the good work.

@Radi85 Radi85 merged commit f5bfbcd into Radi85:develop Nov 4, 2021
@abhiabhi94
Copy link
Collaborator Author

thanks @Radi85, for checking.

@abhiabhi94 abhiabhi94 mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radi85 Radi85 Radi85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhiabhi94 @Radi85