chore: Handle deprecation warnings and drop support for EOL python and django versions #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiabhi94
force-pushed
the
feat/handle-warnings
branch
from
de3fd41
to
635e546
Compare
|
Hey @Radi85, as of now, I have sent the changes in three separate commits for different parts in this commit, let me know if you want me to make them in separate pull-requests. |
abhiabhi94
force-pushed
the
feat/handle-warnings
branch
from
635e546
to
cc3ef08
Compare
Codecov Report
@@ Coverage Diff @@
## develop #249 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 56 56
Lines 1989 1994 +5
Branches 288 289 +1
========================================
+ Hits 1987 1992 +5
Misses 1 1
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abhiabhi94
changed the title
abhiabhi94
force-pushed
the
feat/handle-warnings
branch
from
cc3ef08
to
7d74215
Compare
|
Hey @abhiabhi94, |
updated, 👯 GitHub allows people with write access to the repository to update the branch from the UI. |
- since python 3.6 and django 2.1 had long reached end of life(EOL), we can safely remove support for them.
- also run tests that throw deprecation warnings as errors, so that these are caught earlier.
abhiabhi94
force-pushed
the
feat/handle-warnings
branch
from
7d74215
to
b3a7849
Compare
|
Radico, you probably will need to remove the python 3.6 check from the CI pipeline. |
Radi85
approved these changes
Aug 14, 2022
|
Hey Radico, thanks for taking the time out for reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since python 3.6 and django 2.1 had long reached
end of life(EOL), we can safely remove support for
them.
also run tests that throw deprecation warnings as errors,
so that these are caught earlier.