Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ignore results from django main branch #252

Closed

Conversation

abhiabhi94
Copy link
Collaborator

- there are sometimes breaking changes introducted in django's
  main branch, that other dependencies take time to handle.
  For example: our CI has been broken for almost a month now,
  due to the breaking change in django/django#15797.

  Hence, ignoring the results of the django main branch for now,
  to allow all other patches to be merged.
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #252 (a863cb6) into develop (6c9daac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #252   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           56       56           
  Lines         1989     1989           
  Branches       288      288           
========================================
  Hits          1987     1987           
  Misses           1        1           
  Partials         1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9daac...a863cb6. Read the comment docs.

@abhiabhi94
Copy link
Collaborator Author

Hey @Radi85, it seems the token for test PyPI is not working. Can you please check and review this patch? We would need it to fix the CI, and allow other patches to be merged.

@Radi85
Copy link
Owner

Radi85 commented Aug 13, 2022

Hey @Radi85, it seems the token for test PyPI is not working. Can you please check and review this patch? We would need it to fix the CI, and allow other patches to be merged.

Hey @abhiabhi94, thanks for your PR.

In fact the current repo (master) of pypa/gh-action-pypi-publish is not supported anymore, I have updated to a supported one in #253 and this seems to fix the token issue. However publishing to TestPyPi is only required on staging branch I also fixed that in #253.
Can you please rebase this PR after merging #253 ?

@Radi85
Copy link
Owner

Radi85 commented Aug 13, 2022

Hmmm in fact we have to merge this PR and #253 into one PR in order to fix the whole pipeline. I have added your changes to my PR.

@abhiabhi94 abhiabhi94 closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants