Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vNext - drop obsolites #259

Merged
merged 25 commits into from
May 17, 2019
Merged

vNext - drop obsolites #259

merged 25 commits into from
May 17, 2019

Conversation

mauroservienti
Copy link
Member

@mauroservienti mauroservienti commented Oct 27, 2018

Connected to #258
Depends on #257

Once #257 is merged, rebase on develop and retarget to develop.

@mauroservienti mauroservienti requested a review from a team as a code owner October 27, 2018 13:11
@nazarenomanco
Copy link
Member

@mauroservienti I should have found all the "#if": these are missing because I'm not sure of the correct action:

  • AnalyticsServices (delete?)
#if !SILVERLIGHT && !NETFX_CORE
                this.Identity = Thread.CurrentPrincipal.Identity;
#endif
  • Ensure: #if DEBUG (leave?)

Thanks!

@mauroservienti mauroservienti changed the title [WIP] vNext - drop obsolites vNext - drop obsolites May 17, 2019
@mauroservienti
Copy link
Member Author

Thanks @nazarenomanco, merging.

@mauroservienti mauroservienti merged commit 6a0e9c6 into vnext May 17, 2019
@mauroservienti mauroservienti deleted the drop-obsolites branch May 18, 2019 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants