-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Nphase in UVH5 Memo #1233
Document Nphase in UVH5 Memo #1233
Conversation
Thanks @radonnachie this is really helpful! I think we should also update the pdf. To get it to compile I think you'll need to install |
c47c518
to
fe0c36a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 33 33
Lines 18062 18062
=======================================
Hits 18051 18051
Misses 11 11 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @radonnachie, thank you! The only thing we need to do is to add the compiled pdf so that the pdf in the repo is up to date. I'm happy to do that if you want to give me push access to your fork.
I'd love to @bhazelton, but I cannot (it seems because the fork is not user-owned, but organization owned). So we're at a bit of a stalemate... I suppose if you wanted you could fork from mine PR to me I merge, then we merge here. Or you could just copy paste the documentation to your own branch and get it all done without this PR. I'm not fussed about such a trivial contribution, especially when you're generating the PDF. I did try, but my MikTex is not happy with the task 🤷. Thanks! |
We'll do the simple thing -- I'll merge this and then make another PR with the updated PDF. Thank you for the fix! |
Description
Add an entry for the
Nphase
Header dataset, just above the relatedphase_center_catalog
entry in the UVH5 Memo tex file.Motivation and Context
Without
Nphase
v1.1 UVH5 files cannot be interpreted (#1224).Types of changes
Checklist:
Documentation change checklist: