Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpinning Pinned Messages #10

Closed
shelbaz opened this issue Feb 1, 2018 · 4 comments
Closed

Unpinning Pinned Messages #10

shelbaz opened this issue Feb 1, 2018 · 4 comments
Assignees
@g-harel @Dan-Yoo @erinb90 @veken1199 @Radu-Raicea @shelbaz
Labels
Pin Messages TA-signoff user story
Milestone
Sprint 2

Comments

@shelbaz
Copy link
Collaborator

shelbaz commented Feb 1, 2018 •
edited by Radu-Raicea
Loading

As a user, I want to unpin a pinned message.
[SP: 8]
[Priority: Medium]
[Risk: Low]

1- Expose an interface to the Activities to unpin a message (4h) -> (g-harel, Dan-Yoo, veken1199)
2- Implement a solution to delete relative info from the persistence entity (4h) -> (g-harel, Dan-Yoo, veken1199)
3- Add unpin button to top menu bar (2h) -> (erinb90, Radu-Raicea, shelbaz)
4- Link unpin to interface created (2h) -> (erinb90, Radu-Raicea, shelbaz)
Total: ?
5- Reflect the changes after unpin message is completed (3h) -> (erinb90, Radu-Raicea, shelbaz)
Total: 15h
@shelbaz shelbaz added this to the Sprint 2 milestone Feb 1, 2018
erinb90 referenced this issue Feb 1, 2018
@erinb90
added conversation options menu item to view pinned messages that goe…
8941dd9 
…s to empty activity
@Radu-Raicea Radu-Raicea changed the title Create UI list element in menu bar Unpinning Pinned Messages Feb 2, 2018
@Radu-Raicea Radu-Raicea removed the design label Feb 2, 2018
@Radu-Raicea Radu-Raicea mentioned this issue Feb 2, 2018
Closed
veken1199 referenced this issue Feb 7, 2018
@cool-appz
Related to #12: Refactored the pinMessage method
2a63bb5 
1- moved the implementation up in the hierarchy into "MessageDatabase"
2- added it messages to the res.values.strings.xml
3- completed unpinMessage method with initial successful test
veken1199 pushed a commit that referenced this issue Feb 8, 2018
@cool-appz
# related to #10 and #12:
bb01780 
1- modified the MmsSmsColumn Structure in order to allow for the cursor to read the 'pinned' status
erinb90 added a commit that referenced this issue Feb 8, 2018
@erinb90
#10 added unpin icon, added handleUnpinMessage to ConversationFragment
03cef3f
veken1199 pushed a commit that referenced this issue Feb 8, 2018
@cool-appz
# related to #10 and #12: isPinned Method
73c3aa7 
1- added a new method called "isPinned" to Messaging database as @erinb90 requested
veken1199 pushed a commit that referenced this issue Feb 9, 2018
@cool-appz
# related to #12 and #10: TEST - Pin and unPin test cases
7059d5e 
1- used mockito to test pinning and unpinning behaviour
erinb90 added a commit that referenced this issue Feb 9, 2018
@erinb90
#10 #12 refactored handle pin and unpin methods to reduce duplicated …
2ee1c00 
…code, extracted showToast into separate method
erinb90 added a commit that referenced this issue Feb 9, 2018
@erinb90
#10 #12 set the visibility of the pin and unpin icons based on whethe…
5ed91cb 
…r message is pinned or not
g-harel added a commit that referenced this issue Feb 10, 2018
@g-harel
#10 updated unpin icon for better contrast
5378b40
veken1199 pushed a commit that referenced this issue Feb 10, 2018
@cool-appz
# related to #10 and #12: Refactored Dependencies
ae461c9 
1- Refactored pin interfaces into separate method to facilitate unit testing
2- clean the code
veken1199 pushed a commit that referenced this issue Feb 10, 2018
@cool-appz
# related to #10 and #12: Functional Pin messages Display
581d183
veken1199 pushed a commit that referenced this issue Feb 10, 2018
@cool-appz
# related to #10 and #12 and #11: Unit tests
ec596a3 
1- Testing PinnedMessagesHandler class and its behaviour
veken1199 pushed a commit that referenced this issue Feb 11, 2018
@cool-appz
# related to #10 and #12 and #11: General improvements
71b7bf0 
1- Prevent the user from pinning MMS messages
2- Display the data and the username attached to every pinned message in the pinned messages UI
3- general clean ups
veken1199 pushed a commit that referenced this issue Feb 11, 2018
@cool-appz
# related to #10 and #12 and #11: Unit tests
829e672 
1- Testing PinMessagesHandler class and its behaviour
shelbaz referenced this issue Feb 11, 2018
@shelbaz
implement swipe left and right
cc87df2
veken1199 pushed a commit that referenced this issue Feb 11, 2018
@cool-appz
# related to #10 and #12 and #11: Fixing test bug
b5164b0 
1- Downgraded both of Junit and Powermokito
@g-harel
Copy link
Collaborator

g-harel commented Feb 11, 2018

screenshot_20180210-221155

screenshot_20180210-221219

@Radu-Raicea
Copy link
Owner

Radu-Raicea commented Feb 11, 2018 •
edited
Loading

TASK INPUTS EXPECTED OUTPUT STATUS
Unpin a Message A pinned messaged selected by the user from conversation interface The user will notice unpin button on the screen, Upon click, the message will be unpinned and a feedback will be displayed informing the user that the message is unpinned PASS
Unpin a Message A pinned message within the list of a conversation' pinned messages The messages disappears from the list after clicking on the unpin button PASS
Unpin a Message A pinned messaged selected by the user from conversation interface After unpinning the message, the message details stays unaffected PASS
New database version Running application Able to see new columns added to SMS and MMS table called "pinned" PASS
Reflect changes on database Running application Observe to see the changes in both SMS and MMS tables after pin and unpin operations PASS

@ghost ghost removed the testing label Feb 11, 2018
@Radu-Raicea
Copy link
Owner

Radu-Raicea commented Feb 12, 2018 •
edited
Loading

Implementation time:
Task 1: 2h
Task 2: 3h
Task 3: 3h
Task 4: 1h
Task 5: 3h
Total: 12h

@jinfuchen
Copy link
Collaborator

Demo unpinning pinned messages. All acceptance tests pass.
1- Expose an interface to the Activities to unpin a message (done)
2- Implement a solution to delete relative info from the persistence entity (done)
3- Add unpin button to top menu bar (done)
4- Link unpin to interface created (done)
5- Reflect the changes after unpin message is completed (done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g-harel g-harel

@Dan-Yoo Dan-Yoo

@erinb90 erinb90

@veken1199 veken1199

@Radu-Raicea Radu-Raicea

@shelbaz shelbaz

Labels
Pin Messages TA-signoff user story
Projects
None yet
Milestone
Sprint 2
Development

No branches or pull requests
7 participants
@g-harel @jinfuchen @Dan-Yoo @erinb90 @veken1199 @Radu-Raicea @shelbaz