Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MessageRecord to add a Pinned indication #25

Closed
Radu-Raicea opened this issue Feb 15, 2018 · 1 comment
Closed

Change MessageRecord to add a Pinned indication #25

Radu-Raicea opened this issue Feb 15, 2018 · 1 comment
Assignees
@g-harel @erinb90
Labels
pin message improvements sub-task
Milestone
Sprint 3

Comments

@Radu-Raicea
Copy link
Owner

User Story #19

Estimated Time: 6h
@Radu-Raicea Radu-Raicea added this to the Sprint 3 milestone Feb 15, 2018
@Radu-Raicea Radu-Raicea mentioned this issue Feb 15, 2018
Closed
erinb90 added a commit that referenced this issue Feb 22, 2018
@erinb90
#19 #25 #26 Pinned Message Indicator:
3c11ac5 
-added pinned bit to db columns with methods to set and unset it
-updated pinned message handler to call these methods when user pins or unpins a message
-added isPinned to MessageRecord that checks status of pinned bit
-added small pin icon to conversation item that is visible when message is pinned
erinb90 added a commit that referenced this issue Feb 26, 2018
@erinb90
#19 #25 updated PinnedMessagesHandlerTests to verify that markAsPinne…
a7e56e0 
…d/Unpinned was called after a successful pin or unpin, fixed typo in class name
@erinb90
Copy link
Collaborator

erinb90 commented Mar 1, 2018

Implementation time: 3h

@erinb90 erinb90 closed this as completed Mar 1, 2018
@ghost ghost removed the testing label Mar 1, 2018
@erinb90 erinb90 mentioned this issue Mar 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g-harel g-harel

@erinb90 erinb90

Labels
pin message improvements sub-task
Projects
None yet
Milestone
Sprint 3
Development

No branches or pull requests
4 participants
@g-harel @erinb90 @veken1199 @Radu-Raicea