Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a nickname #36

Closed
Radu-Raicea opened this issue Feb 15, 2018 · 1 comment
Closed

Removing a nickname #36

Radu-Raicea opened this issue Feb 15, 2018 · 1 comment
Assignees
@Dan-Yoo
Labels
nickname TA-signoff user story
Milestone
Sprint 3

Comments

@Radu-Raicea
Copy link
Owner

Radu-Raicea commented Feb 15, 2018 •
edited by veken1199
Loading

As an user, I want to be able to remove another user’s nickname.

[SP: 2]
[Priority: High]
[Risk: Low]

  1. Provide a public interface to unset the nickname #41 : Provide a public interface to unset the nickname
  2. Implement UI components to allow user to unset nickname in conversation settings #42 : Implement UI components to allow user to unset nickname in conversation settings

Total: 3h
@Radu-Raicea Radu-Raicea added this to the Sprint 3 milestone Feb 15, 2018
This was referenced Feb 15, 2018
Closed
Closed
Closed
@Dan-Yoo
Copy link
Collaborator

Dan-Yoo commented Mar 4, 2018

TASK INPUTS EXPECTED OUTPUT STATUS
Reset nickname click when recipient has no nickname recipient with no nickname No change in the displayed name PASS
Reset nickname click when recipient has nickname and no name recipient with nickname Nickname is set to null and address is shown instead PASS
Reset nickname click when recipient has nickname and name recipient with nickname and name Nickname is set to null and name is shown instead PASS

@veken1199 veken1199 removed the testing label Mar 5, 2018
veken1199 pushed a commit that referenced this issue Mar 5, 2018
@cool-appz
# related to #34, #35, #36 : Unit tests to capture set/change/remove …
cc60a77 
…nicknames

1- It covers mostly Recipient Class and how setNickname function manipulates getName()
@veken1199 veken1199 mentioned this issue Mar 5, 2018
Merged
veken1199 pushed a commit that referenced this issue Mar 5, 2018
@cool-appz
Merge pull request #61 from Radu-Raicea/Nickname-getter-setter-tests
32916ab 
# related to #34, #35, #36 : Unit tests to capture set/change/remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dan-Yoo Dan-Yoo

Labels
nickname TA-signoff user story
Projects
None yet
Milestone
Sprint 3
Development

No branches or pull requests
4 participants
@jinfuchen @Dan-Yoo @veken1199 @Radu-Raicea