Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: The app breaks when I pin my own text message in a group chat #55

Closed
veken1199 opened this issue Mar 3, 2018 · 2 comments
Closed

Bug: The app breaks when I pin my own text message in a group chat #55

veken1199 opened this issue Mar 3, 2018 · 2 comments
Assignees
@veken1199
Labels
bug Something isn't working sub-task
Milestone
Sprint 4

Comments

@veken1199
Copy link
Collaborator

veken1199 commented Mar 3, 2018 •
edited by Radu-Raicea
Loading

User Story #54

Estimated Time: 1h
@veken1199 veken1199 self-assigned this Mar 3, 2018
@veken1199 veken1199 added bug Something isn't working sub-task labels Mar 3, 2018
@veken1199 veken1199 changed the title Bug:The app breaks when I pin my own text message in a groupchat Bug: The app breaks when I pin my own text message in a groupchat Mar 3, 2018
@veken1199 veken1199 added this to the Sprint 4 milestone Mar 3, 2018
@veken1199 veken1199 mentioned this issue Mar 3, 2018
Closed
@veken1199 veken1199 added the to do label Mar 4, 2018
@veken1199 veken1199 changed the title Bug: The app breaks when I pin my own text message in a groupchat Bug: The app breaks when I pin my own text message in a group chat Mar 4, 2018
veken1199 pushed a commit that referenced this issue Mar 6, 2018
@cool-appz
Merge pull request #65 from Radu-Raicea/Bug-groupchat-pin-message
b68a5a6 
Bug fix #55: Pinning self text messages in groupchat:

For some reason, the self-pinned text messages are rendered as MediaMessages which in fact they are simple text messages. The bug has been fixed by added another verification on top of isMms which basically check if the message casted to mms can return filled slider. Sliders tell us if the message contains an attachment.
@ghost ghost removed the in progress label Mar 6, 2018
@Radu-Raicea
Copy link
Owner

@veken1199
Please put implementation hours.

@Radu-Raicea Radu-Raicea reopened this Mar 8, 2018
@veken1199 veken1199 removed the testing label Mar 11, 2018
@veken1199
Copy link
Collaborator Author

Implementation time : 1h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veken1199 veken1199

Labels
bug Something isn't working sub-task
Projects
None yet
Milestone
Sprint 4
Development

No branches or pull requests
2 participants
@veken1199 @Radu-Raicea