Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fully functional pin feature in group chat #63

Closed
veken1199 opened this issue Mar 5, 2018 · 1 comment
Closed

Allow fully functional pin feature in group chat #63

veken1199 opened this issue Mar 5, 2018 · 1 comment
Assignees
@veken1199
Labels
Pin Messages sub-task
Milestone
Sprint 4

Comments

@veken1199
Copy link
Collaborator

veken1199 commented Mar 5, 2018 •
edited by Radu-Raicea
Loading

User Story #54

Estimated Time: 1h
@veken1199 veken1199 self-assigned this Mar 5, 2018
@veken1199 veken1199 added this to the Sprint 4 milestone Mar 5, 2018
@veken1199 veken1199 mentioned this issue Mar 5, 2018
Closed
veken1199 pushed a commit that referenced this issue Mar 8, 2018
@cool-appz
Bug fix #58 and #63:
678dce9 
1- Removed the additional verification we placed last semester to block audio and video testing
2- Made sure that we can pin and unpin videos and audios in both 1-1 conversation and groupchat
veken1199 pushed a commit that referenced this issue Mar 8, 2018
@cool-appz
Related #58, #63, #62:
8a9b14b 
1- Added Audio stub object to pinned messages
2- Added pinned audio xml views
3- Introduced isAudio and isVideo to pinnedMessagesAdapter
4- Refactored the way pinned images and videos are being verified in pinned Messages adapter
veken1199 pushed a commit that referenced this issue Mar 8, 2018
@cool-appz
Related #58, #63, #62:
577fc26 
1- Added Document stub object to pinned messages
2- Added pinned Document xml views
3- Introduced isDocument() to PinnedMessagesAdapter
4- added some code cleanup in PinnedMessagesAdapter class
veken1199 pushed a commit that referenced this issue Mar 9, 2018
@cool-appz
Merge pull request #79 related #58, #63, #62
f70c288 
Pin message video audio attachments in conversation and group chat
Radu-Raicea added a commit that referenced this issue Mar 17, 2018
@Radu-Raicea
Pinmessages ui tests - related to stories #54, #63, #85, #87
e93376c
@veken1199
Copy link
Collaborator Author

implementation : 2h

@veken1199 veken1199 removed the testing label Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veken1199 veken1199

Labels
Pin Messages sub-task
Projects
None yet
Milestone
Sprint 4
Development

No branches or pull requests
1 participant
@veken1199