Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search bar UI (Display search bar UI and return to previous UI) #68

Closed
Radu-Raicea opened this issue Mar 8, 2018 · 1 comment
Closed

Add search bar UI (Display search bar UI and return to previous UI) #68

Radu-Raicea opened this issue Mar 8, 2018 · 1 comment
Assignees
@erinb90 @shelbaz
Labels
search sub-task
Milestone
Sprint 4

Comments

@Radu-Raicea
Copy link
Owner

User Story #66

Estimated Time: 6h
@Radu-Raicea Radu-Raicea added this to the Sprint 4 milestone Mar 8, 2018
This was referenced Mar 8, 2018
Closed
Closed
shelbaz added a commit that referenced this issue Mar 8, 2018
@shelbaz
Initial commit search frontend #66 #68
0c4efec
veken1199 pushed a commit that referenced this issue Mar 9, 2018
@cool-appz
realated to #66 #68 : Bug fix and Clean up
d2876eb 
1- fixed the bug for which it will disable the InputPanel when you click search conversation menu item
2- added isSearchMode to help us toggle between the search view and conversation view
3- added the logic to show/disable the InputPanel
shelbaz added a commit that referenced this issue Mar 12, 2018
@shelbaz
Added search bar and button, up and down arrows to layout, logic to d…
08ace1a 
…eal with hardware back press #66 #68
shelbaz added a commit that referenced this issue Mar 12, 2018
@shelbaz
Autofocus search, and fix bug that needed 2x clicked of SearchConvo #66
78a5cc8 
#68 #82
shelbaz added a commit that referenced this issue Mar 12, 2018
@shelbaz
Forgot to include focus Search in last commit.... #66 #68
33a6a98
shelbaz added a commit that referenced this issue Mar 12, 2018
@shelbaz
Refactoring code, naming conventions and typos, made arrows clickable…
f7807f4 
… (listener to be implemented) #66 #68
erinb90 added a commit that referenced this issue Mar 13, 2018
@erinb90
#66 #68 removed "go" button in search bar, removed space between arro…
45f40d4 
…ws, naming, formatting
erinb90 added a commit that referenced this issue Mar 13, 2018
@erinb90
#66 #68 changed search bar background colors to go with both light an…
1e253f8 
…d dark themes
shelbaz added a commit that referenced this issue Mar 15, 2018
@shelbaz
Moved positioning of arrows to right side (closer to thumb) #66 #68
304e277
veken1199 pushed a commit that referenced this issue Mar 16, 2018
@cool-appz
related to #68 and #70 : Search ui improvements
bb864ca 
1- added Search counter to backend and frontend
2- heptic feedback to both up and down search buttons
veken1199 pushed a commit that referenced this issue Mar 16, 2018
@cool-appz
related to #68 and #70 : Search ui improvements
b61fed4 
1- Toast to tell the notify the users when when close the search mode
2- better ui elements for both search field and search counter
veken1199 pushed a commit that referenced this issue Mar 18, 2018
@cool-appz
related to #68 : UI search counter improvement to cover the case in w…
21d646a 
…hich no search is found

related to #68 : code format
@shelbaz
Copy link
Collaborator

shelbaz commented Mar 18, 2018

Implementation: 7hr

@shelbaz shelbaz closed this as completed Mar 18, 2018
@ghost ghost removed the in progress label Mar 18, 2018
veken1199 pushed a commit that referenced this issue Mar 18, 2018
@cool-appz
Merge pull request #92 from Radu-Raicea/search-ui-improvement
f2f6ace 
related to #68 : UI search counter improvement to cover the case in w…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erinb90 erinb90

@shelbaz shelbaz

Labels
search sub-task
Projects
None yet
Milestone
Sprint 4
Development

No branches or pull requests
4 participants
@erinb90 @veken1199 @Radu-Raicea @shelbaz