Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider passing bench reference to onCompleteBenchmark getResult getReport #19

Closed
naugtur opened this issue Nov 15, 2024 · 0 comments · Fixed by #20
Closed

Consider passing bench reference to onCompleteBenchmark getResult getReport #19

naugtur opened this issue Nov 15, 2024 · 0 comments · Fixed by #20

Comments

@naugtur
Copy link
Contributor

naugtur commented Nov 15, 2024

When there's more than one task in the suite, it's super annoying to have to capture the name from before or after in the returned code that puts it in the context to get it in results in onCompleteBenchmark as the only option to aggregate results across runs and differentiating the tasks.

I don't know how to get the bench task name in the getR* functions to return the right value.

Alternatively, having an option to pass plugin constructor and get it instantiated separately for each task would make plugin authoring easier.

thoughts?

@naugtur naugtur changed the title Consider passing bench reference to onCompleteBenchmark Consider passing bench reference to onCompleteBenchmark getResult getReport Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant