Only add excludes to find command if it's defined #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If excludes is not set in the yaml, or set to "", then the following error occurs: /entrypoint.sh: line 44: local: `': not a valid identifier When excludes is empty, it causes handling of the for loop over its contents to fail. To prevent this, check that the variable is non-empty prior to looping over its contents. In addition to this fix, document this feature in the readme and fix some typos there. Fixes RafikFarhad#7
|
I have not tested these changes since I don't know how to test github actions. |
You can specify a specific commit like this: jobs:
check-formatting:
# ...
steps:
# ...
- name: clang-format
uses: kadler/clang-format-github-action@6a2185a0aef1c8f132b026804b66eac35a231ff4
with:
sources: "**/*.hpp,**/*.h,**/*.cpp," |
|
Thank you very much 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If excludes is not set in the yaml, or set to "", then the following error occurs:
/entrypoint.sh: line 44: local: `': not a valid identifier
When excludes is empty, it causes handling of the for loop over its contents to fail. To prevent this, check that the variable is non-empty prior to looping over its contents.
In addition to this fix, document this feature in the readme and fix some typos there.
Fixes #7