Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying naming of interrupt vectors on new AVR MCUs #19

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Clarifying naming of interrupt vectors on new AVR MCUs #19

merged 1 commit into from
Nov 24, 2020

Conversation

trembel
Copy link
Contributor

@trembel trembel commented Nov 24, 2020

This solves #16.
The commit checks if module-instance exists, and if yes, it appends name to module-instance, if not, name stays name.
On the new AVR series, its even a bug fix, since else multiple interrupts would have the same name.

Signed-off-by: trembel silvano.cortesi@hotmail.com

@Rahix Rahix linked an issue Nov 24, 2020 that may be closed by this pull request
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(moved from the other PR)

src/atdf/interrupt.rs Outdated Show resolved Hide resolved
src/atdf/interrupt.rs Outdated Show resolved Hide resolved
@Rahix Rahix added the enhancement New feature or request label Nov 24, 2020
Signed-off-by: trembel <silvano.cortesi@hotmail.com>
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarifying naming of interrupt vectors on new AVR MCUs
2 participants