Use bit size instead of byte size when parsing bitmasks. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses sizeof usize but that is in bytes. We need the size in bits. The bug appeared when parsing the 32bit LOCK bit register. For smaller sizes the old behaviour worked because sizeof::<usize> == 8 on most systems.
|
Huh, that does make sense to me at least! Cc @octycs, you originally wrote this code. Any comments? I'd say this change looks correct, what do you think? |
Rahix
approved these changes
Dec 3, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses sizeof usize but that is in bytes. We need the size in bits. The bug
appeared when parsing the 32bit LOCK bit register. For smaller sizes the old
behaviour worked because
sizeof::<usize> == 8on most systems.