Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not read ocd-rw for register access mode, but read rw #24

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Do not read ocd-rw for register access mode, but read rw #24

merged 1 commit into from
Mar 18, 2021

Conversation

xoriath
Copy link
Contributor

@xoriath xoriath commented Mar 18, 2021

Elements without a rw attribute is RW.

SVD Access does not have a 'none' access, which can be described
with and empty rw attribute in atdf. For now, pass it down as None.

This fixes #23

@xoriath
Do not read ocd-rw for register access mode, but read rw
9f00eae 
Elements without a rw attribute is RW.

SVD Access does not have a 'none' access, which can be described
with and empty rw attribute in atdf. For now, pass it down as None.

This fixes Rahix#23
@Rahix Rahix added the bug Something isn't working label Mar 18, 2021
@Rahix
Copy link
Owner

Rahix commented Mar 18, 2021

Okay, ran a small regression test, everything looks good. The biggest change is that we're now explicitly emitting an <access> element everywhere but I guess that doesn't hurt. Thanks a lot!

@Rahix Rahix merged commit a189276 into Rahix:master Mar 18, 2021
@xoriath
Copy link
Contributor Author

xoriath commented Mar 18, 2021

@Rahix is there a regression suite? Or just run and look? :)

@xoriath
Copy link
Contributor Author

xoriath commented Mar 18, 2021

And, it should not hurt emitting it for all elements... I have never been a huge fan of the 'inheritance' in SVD, but... I guess it could be compressed a bit if access is only emitted if it differs from a parent access ...

@Rahix
Copy link
Owner

Rahix commented Mar 18, 2021

is there a regression suite? Or just run and look? :)

I built avr-device with both the old and new version and diffed the generated files to look for differences. So not a regression suite but better than random sampling I guess ^^

And, it should not hurt emitting it for all elements...

Yeah, absolutely, I agree that explicit is better than relying on inheritance.

@xoriath xoriath deleted the register-access-mode branch March 19, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong parsing of register access mode
2 participants
@xoriath @Rahix