-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement interrupts as specified in #2 #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the implementation! There are a few things, I added comments where due. Although in general, good work! 👍
One more thing: Why are there two commits? Please squash your changes into a single commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things, then I'll be happy 😃
There is one more issue: The interrupts are not sorted. You can fix this, using code like Lines 37 to 42 in c7eb572
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Please squash your changes, so I can merge them!
This commit makes atdf2svd parse the interrupt list from the source file and adds all interrupts to the CPU peripheral in the generated svd. Fixes Rahix#2 Signed-off-by: offdroid <filip.skubacz.public@gmail.com>
No description provided.