Ensure we don't generate empty enumerated values #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we never generate `ValueRestriction::Enumerated` for an empty list of enumerated values. This will become important when switching to svd-rs as it will refuse accepting such value restrictions. So far, this situation was only observed for fields where we filter out invalid enumerated values. But the check will also cover hypothetical ATDF files which have an empty list of enumerated values for some field. Fixes: 62e5b60 ("Drop invalid enumerated values with a warning")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we never generate
ValueRestriction::Enumeratedfor an empty list of enumerated values. This will become important when switching to svd-rs as it will refuse accepting such value restrictions.So far, this situation was only observed for fields where we filter out invalid enumerated values. But the check will also cover hypothetical ATDF files which have an empty list of enumerated values for some field.
Fixes: 62e5b60 ("Drop invalid enumerated values with a warning") from #14