Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atmega-hal:attiny85 support #157

Merged
merged 3 commits into from
Mar 8, 2021
Merged

atmega-hal:attiny85 support #157

merged 3 commits into from
Mar 8, 2021

Conversation

explicite
Copy link
Contributor

atmega-hal: ATtiny85 support

@explicite explicite mentioned this pull request Mar 7, 2021
Merged
@Rahix
Copy link
Owner

Rahix commented Mar 7, 2021

Ah, sorry, the ATtiny's shouldn't go into atmega-hal, they should have their own attiny-hal crate... :/

@Rahix Rahix added the mcu-support Support for a new Microcontroller label Mar 7, 2021
@Rahix Rahix added this to the New APIs milestone Mar 7, 2021
@Rahix
Copy link
Owner

Rahix commented Mar 7, 2021

Do you want to have a go at creating it or should I build up the base for you to work with? Essentially, it should be a mirror copy of atmega-hal without any major differences.

Rahix
Rahix reviewed Mar 8, 2021
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got one super minor nit-pick apart from that it looks great! Thanks, btw, for helping out so much, I really appreciate it :)

mcu/attiny-hal/src/lib.rs Outdated Show resolved Hide resolved
mcu/attiny-hal/src/lib.rs Show resolved Hide resolved
@Rahix Rahix mentioned this pull request Mar 8, 2021
Open
42 tasks
@explicite @Rahix
Update mcu/attiny-hal/src/lib.rs
9b02656 
Co-authored-by: Rahix <rahix@rahix.de>
@Rahix Rahix self-requested a review March 8, 2021 11:52
@Rahix Rahix merged commit 114d940 into Rahix:next Mar 8, 2021
@explicite explicite deleted the atmega-hal/ATtiny85 branch March 8, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Awaiting requested review from Rahix

Assignees
No one assigned
Labels
mcu-support Support for a new Microcontroller
Projects
None yet
Milestone
New APIs
Development

Successfully merging this pull request may close these issues.
2 participants
@explicite @Rahix