Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refactored support for Arduino Diecimila #177

Merged
merged 9 commits into from
Apr 24, 2021
Merged

Add refactored support for Arduino Diecimila #177

merged 9 commits into from
Apr 24, 2021

Conversation

explicite
Copy link
Contributor

@explicite explicite commented Apr 23, 2021 •
edited
Loading

Support for Diecimila

  • arduino-hal
  • examples
    • blink
    • adc
    • usart
    • i2c
    • spi
  • ravedude

@explicite
Copy link
Contributor Author

explicite commented Apr 23, 2021 •
edited
Loading

@Rahix should I move existing examples or follow basic set - like in e.g Leonardo?
Last question... how can help me to test this examples? I was trying to buy one board but I cannot find any...

Rahix
Rahix requested changes Apr 23, 2021
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from one typo I spotted :) Thanks a lot! I don't have such a board either, so let's just hope for the best... Maybe @kallemooo who originally submitted Diecimila support can run tests?

examples/arduino-diecimila/.cargo/config.toml Outdated Show resolved Hide resolved
@Rahix Rahix added the mcu-support Support for a new Microcontroller label Apr 23, 2021
@Rahix Rahix added this to the New APIs milestone Apr 23, 2021
@Rahix Rahix mentioned this pull request Apr 23, 2021
Open
42 tasks
@explicite explicite requested a review from Rahix April 24, 2021 20:14
@explicite
Copy link
Contributor Author

PWM example need to be done after PWM refactor.

@explicite explicite marked this pull request as ready for review April 24, 2021 20:47
Rahix
Rahix approved these changes Apr 24, 2021
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! I don't thing we have much of an option other than merging this and hoping if someone uses it they'll report any issues.

ravedude/src/board.rs
Comment on lines +172 to +175
programmer: "arduino",
partno: "atmega168",
baudrate: Some(19200),
do_chip_erase: false,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't verify those settings, can we? :/

examples/arduino-diecimila/src/bin/diecimila-spi-feedback.rs Show resolved Hide resolved
@Rahix Rahix changed the title Diecimila support Add refactored support for Arduino Diecimila Apr 24, 2021
@Rahix Rahix merged commit c299f65 into Rahix:next Apr 24, 2021
@explicite explicite deleted the diecimila branch April 25, 2021 19:30
@Rahix Rahix mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
mcu-support Support for a new Microcontroller
Projects
None yet
Milestone
New APIs
Development

Successfully merging this pull request may close these issues.
2 participants
@explicite @Rahix