-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atmega328p-hal & arduino-uno support #3
Conversation
Please also port the examples from |
Just as a heads up: For the |
Yeeeeeaaaaahhhhhhhhh bbbooiiiiiiiiiiiiiiiiiiii First try, the blink example works on my Uno. 😄 |
@Rahix The blink, serial, and panic examples have been ported and tested. I don't have any hardware with which to test I2C example however. Are you willing to consider this completed without that example? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeeeeeaaaaahhhhhhhhh bbbooiiiiiiiiiiiiiiiiiiii
First try, the blink example works on my Uno.
Heh, I know that feeling all to well ;) Makes all the hard work worth it!
Thank you very much for your port! I have added a few comments, once those are resolved I am happy to merge.
Are you willing to consider this completed without that example?
Please add the i2cdetect
example and at least check that it reports an empty bus. I might have access to some ATmega328P based hardware soon, I will test it in detail then.
Thanks for the review @Rahix . I'll try to work on those items tonight (Central Standard Time). |
@Rahix All of your requested changes are complete, and the i2cdetect example has been ported. To confirm, is this the expected serial output?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! The i2cdetect
detect output also looks like it should. I will try to test it against some actual bus soon, though I don't expect any surprises there.
Thank you very much for your work on this! 😃
Created a new crate for atmega328p, copied the code over and updated the list of GPIO pinouts and updated the specific pins used for USART and TWI.