specs: Add option to print memory usage #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahix
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Hi, thanks a lot for the contribution, this is a great idea!
However, I'd like to split apart the change of updating the specs to latest upstream and your addition of the new flag. Please either enable the "allow edits to this PR by contributiors" flag for this pull-request, then I can take care of it. Or just split your change into two commits yourself. Whatever you prefer :)
hankertrix
force-pushed
the
main
branch
2 times, most recently
from
a970ada
to
c222e69
Compare
|
Okay, I have split the commits as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also synced all the specs with upstream.
Implements #398.