Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make access to pinmask/driver of pin public #23

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

t-moe
Copy link
Contributor

@t-moe t-moe commented Feb 15, 2024

This is useful for me.
I configure the interrupts of the port expander in my own code (outside of this crate) and its helpful to know the pin mask of a pin...

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the PR! I think it is a good idea to provide an escape hatch here for usecases like yours. However I have one concern regarding the API, see below.

src/pin.rs Outdated Show resolved Hide resolved
@Rahix Rahix merged commit c7f86d1 into Rahix:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants