Improved favorites movie ui improvements #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajashekarRaju
requested changes
Apr 12, 2023
...c/main/java/com/developersbreach/composeactors/domain/use_case/RemoveFavoriteMovieUseCase.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/developersbreach/composeactors/ui/screens/favorites/FavoriteViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/developersbreach/composeactors/ui/screens/movieDetail/MovieDetailViewModel.kt
Outdated
Show resolved
Hide resolved
| Icon( | ||
| painter = painterResource(id = R.drawable.ic_favorite_red), | ||
| contentDescription = null, | ||
| tint = Color.Red |
There was a problem hiding this comment.
Suggested change
| tint = Color.Red | |
| tint = MaterialTheme.colors.primary |
We should not introduce any new colors in any screens.
Since this is an icon, please use
light_primary from the Color design system which is equivalent to MaterialTheme.colors.primary
and since we are supporting light/dark theme, the system will automatically use dark_primary in dark theme.
And now since we do this, we have problem in few scenarios where the image banner of the movie background might lookalike favorite icon, which makes icon visibility partially not visible. The solution to this is, we will have some scrim background for whole width so that the icon will be always visible.
So over all we will have text to left, icon to right and this row will be placed at the bottom of the banner.
Background - MaterialTheme.colors.surface
Icon tint - MaterialTheme.colors.primary
text color - MaterialTheme.colors.primary
...ava/com/developersbreach/composeactors/ui/screens/favorites/tabs/FavoriteMoviesTabContent.kt
Outdated
Show resolved
Hide resolved
...ava/com/developersbreach/composeactors/ui/screens/favorites/tabs/FavoriteMoviesTabContent.kt
Outdated
Show resolved
Hide resolved
...ava/com/developersbreach/composeactors/ui/screens/favorites/tabs/FavoriteMoviesTabContent.kt
Outdated
Show resolved
Hide resolved
RajashekarRaju
approved these changes
Apr 15, 2023
...rc/main/java/com/developersbreach/composeactors/domain/useCase/RemoveFavoriteMovieUseCase.kt
Outdated
Show resolved
Hide resolved
...ava/com/developersbreach/composeactors/ui/screens/favorites/tabs/FavoriteMoviesTabContent.kt
Outdated
Show resolved
Hide resolved
RajashekarRaju
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task related to roadmap v0.3.0