Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Prayer Time Calculator #1259

Merged
merged 13 commits into from
Jun 14, 2024
Merged

Added Prayer Time Calculator #1259

merged 13 commits into from
Jun 14, 2024

Conversation

samarsajad
Copy link
Contributor

@samarsajad samarsajad commented Jun 7, 2024

Fixes Issue🛠️

Closes #1185

Description👨‍💻

A simple prayer time calculator that uses user's location to calculate the prayer timing.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @samarsajad, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit e2fc678
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/666c81bc619dfe00088783a1
😎 Deploy Preview https://deploy-preview-1259--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samarsajad
Copy link
Contributor Author

Please review my pull request @Rakesh9100

@samarsajad
Copy link
Contributor Author

Can you please review my pull request so that i can work on other issue @Rakesh9100

@Rakesh9100 Rakesh9100 changed the title prayer time calculator added Added Prayer Time Calculator Jun 11, 2024
@Rakesh9100
Copy link
Owner

Pls add your calculator folder inside Calculators folder and make the necessary changes by making the new commits in this same PR @samarsajad

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 11, 2024
@samarsajad
Copy link
Contributor Author

I changed the directory. Please take a look @Rakesh9100

@Rakesh9100
Copy link
Owner

image

Why location is undefined, and do this application use our location or uses the inputs given by the user @samarsajad

@samarsajad
Copy link
Contributor Author

It uses the person's location. I couldn't solve the location undefined part. It takes user's input as well but also uses location @Rakesh9100

@Rakesh9100
Copy link
Owner

Either it will use our input or the location that the user allows to the browser, so see to this and also try to fix the undefined part @samarsajad

@samarsajad
Copy link
Contributor Author

The API I used had a parameter for city & Country. So I put those. But it also asks for the location when we use it. Can you please help me figure out what I am missing in this cause I tried so hard to figure out this undefined location part & didn't succeed @Rakesh9100

@Rakesh9100
Copy link
Owner

Okay, I will look over that bug afterward whenever I am free @samarsajad

@Rakesh9100 Rakesh9100 merged commit ea51e83 into Rakesh9100:main Jun 14, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @samarsajad

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points and removed question 🤔 Further information is requested labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Prayer Time Calculator
2 participants