Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Angle Between Two Lines Calculator #1435

Closed
wants to merge 14 commits into from

Conversation

AMS003010
Copy link
Contributor

@AMS003010 AMS003010 commented Jun 25, 2024

Fixes Issue🛠️

Closes #1123

Description👨‍💻

I have added Angle between two lines Calculator which calculates the angle between two lines. The line equations are given as input and the angle between them is returned as output in degrees.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AMS003010, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit ff00a0b
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6688da5ef9bcf200081d5eab
😎 Deploy Preview https://deploy-preview-1435--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nihal4777
Copy link

@AMS003010 Fix the issue in main index.html file.
image

@Rakesh9100
Copy link
Owner

Why the files of Frames-Timecode-Calculator is showing, fix the conflict in this same PR @AMS003010

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 27, 2024
@AMS003010
Copy link
Contributor Author

Sorry got caught up, I'll fix it by today

@AMS003010
Copy link
Contributor Author

@Rakesh9100 Sorry for the delay 😅

I have fixed all changes and fixed all issues. I have reviewed and made sure that there are no issues.

@Nihal4777
Copy link

@AMS003010 The page is not responsive. Are you going to do that?
image

@AMS003010
Copy link
Contributor Author

I'll look into it...

@AMS003010
Copy link
Contributor Author

@Rakesh9100 I have made it responsive

@Rakesh9100 Rakesh9100 changed the title Added Angle between two lines Calculator Added Angle Between Two Lines Calculator Jul 1, 2024
@Rakesh9100
Copy link
Owner

Why the files of Frames-Timecode-Calculator is showing, fix the conflict in this same PR @AMS003010

This is still not fixed, I tried to delete by making commit but it deleted the files originally @AMS003010

@AMS003010
Copy link
Contributor Author

I'll look into it....

@AMS003010
Copy link
Contributor Author

@Rakesh9100
I have done the necessary
It should be fine now

@Rakesh9100
Copy link
Owner

https://github.com/Rakesh9100/CalcDiverse/pull/1435/files

Check here, number of files changed are 13 which should not be @AMS003010

@AMS003010
Copy link
Contributor Author

Yes it does say 13 files but that is because I had made a lot of commits to this issue (which included both addition and deletion). I have only made made changes in my frames-timecode-calculator folder and I have added that calculator in the main index.html

@Rakesh9100
Copy link
Owner

The file changes of Frames-Timecode-Calculator should not show up in this PR by any chance @AMS003010

@AMS003010
Copy link
Contributor Author

Sure I will look into it....

@Rakesh9100
Copy link
Owner

Any update, fix this ASAP @AMS003010

@AMS003010
Copy link
Contributor Author

I'll try to call a new PR only on those changes...
I close this one as I am not able to revert to previous changes

@AMS003010 AMS003010 closed this Jul 6, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Angle Between Two Lines Calculator
3 participants