Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are not detected when they occur outside the Pod pages #52

Open
JJ opened this issue Oct 15, 2019 · 4 comments
Open

Changes are not detected when they occur outside the Pod pages #52

JJ opened this issue Oct 15, 2019 · 4 comments
Assignees

Comments

@JJ
Copy link
Contributor

JJ commented Oct 15, 2019

Documentable update will simply not do anything if, say, template/footer.html is changed.

@JJ JJ added the bug Something isn't working label Oct 15, 2019
@antoniogamiz
Copy link
Collaborator

So to fix this I will need to store a checksum or something of main.mustache somewhere (maybe in documentable.json). I think main.mustache is the only file right now whose modifications would affect to all HTML pages. Well, template/tg-fragment.html too.

What do you think?

@JJ
Copy link
Contributor Author

JJ commented Jul 24, 2020

I think it's probably better if you use the same mechanism, like "baking in" the HTML in a pod that is then cached. You can do that if you assign it to a variable in a BEGIN phaser, I think.

@antoniogamiz
Copy link
Collaborator

Store the main.mustache and tg-fragment.html inside a Pod and then cache that? Hum, I will need to investigate that.

@JJ
Copy link
Contributor Author

JJ commented Jul 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants