Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation_EN.json #966

Merged
merged 6 commits into from
May 17, 2021
Merged

Update translation_EN.json #966

merged 6 commits into from
May 17, 2021

Conversation

discip
Copy link
Collaborator

@discip discip commented May 10, 2021

hopefully helpful changes

],
"desc": "Advanced options"
"desc": "Advanced settings"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency reasons

@@ -171,14 +171,14 @@
"Auto",
"start"
],
"desc": "Starts the iron into soldering mode on power up <O=off | S=soldering | Z=sleep | R=sleep at room temperature>"
"desc": "On power up <O=don't heat | S=heat up to soldering temp | Z=heat up to sleep temp and only heat up to soldering temp when moved | R=only heat up to soldering temp when moved>"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is still not clear enough, maybe someone else will be able to find the right words.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about starting with "Behaviour on power up: " (or "behavior" if you prefer AmE)?

I think the description for "Z" is perhaps a bit too long. Can we just say "enter sleep mode" to imply "only heat up to soldering temp when moved"? But this wouldn't be as clear.

@@ -297,14 +297,14 @@
"Power pulse",
"delay"
],
"desc": "Delay before keep-awake pulse is triggered (x 2.5s)"
"desc": "Delay before keep-awake pulse is triggered <x 2.5s>"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convention I know of here is to use () rather than <> but also not really bothered. Does anyone have an opinion?

Copy link
Collaborator Author

@discip discip May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ralim
Good morning Sir.
I changed these, because in all the other descriptions <> is used.
I myself would prefer () over <> and I initially thought about replacing all <> with (), but didn't dare to.
Or am I mixing up something here?
Are you referring to these 2 occurrences only (x 2.5s)?
thanks
kind regards

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning :)

I was referring to them as a whole. I'm also a bit "eh" and not worried really, so long as they all match I'm happier.

Truth told, I rarely look at the descriptions so I hadn't noticed the trend to <>.

Happy to merge as is, or go to (), your preference is fine by me here :)

Copy link
Contributor

@vini-nu vini-nu May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opinion:

< > should be used then documenting combobox like selections.

( ) should be used then there is optional not necessary information about the setting like guidelines, recommendations.

User should not do extra math to know what value really means. However maybe in this case [ ] should be used to determine stepping coefficient and snippet could be placed to description beginning, instead of the end.
[x 2.5s] Delay before keep-awake pulse is triggered.

Every description should end with dot, so user knows that the will is the end of the message.


Anyways there should be ruling consistence in whole file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ralim
Sorry, but I did not want to open an extra issue on the following:
Could you please clarify, what this setting is meant for?

"desc": "Power source. Sets cutoff voltage. <DC 10V> <S 3.3V per cell, disable power limit>"

Especially the disable power limit is confusing.
Or am I missing something here?

Thank you in advance.

@@ -269,14 +269,14 @@
"Allow locking",
"buttons"
],
"desc": "When soldering, long press both buttons, to lock them <D=disable | B=\"boost mode\" only | F=full locking>"
"desc": "While soldering, press both buttons long to lock them <D=disable | B=boost mode only | F=full locking>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "When in soldering mode, hold down both buttons to toggle button locking"?

@@ -171,14 +171,14 @@
"Auto",
"start"
],
"desc": "Starts the iron into soldering mode on power up <O=off | S=soldering | Z=sleep | R=sleep at room temperature>"
"desc": "On power up <O=don't heat | S=heat up to soldering temp | Z=heat up to sleep temp and only heat up to soldering temp when moved | R=only heat up to soldering temp when moved>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about starting with "Behaviour on power up: " (or "behavior" if you prefer AmE)?

I think the description for "Z" is perhaps a bit too long. Can we just say "enter sleep mode" to imply "only heat up to soldering temp when moved"? But this wouldn't be as clear.

@discip
Copy link
Collaborator Author

discip commented May 11, 2021

Hopefully these changes are somewhat acceptable now. 😊

@vinigas

  1. I am going with () and
  2. about the thing with a . at the end: I had a discussion on that and was told, that one does not put periods there, because in most cases the description texts are no sentences, but rather ellipses.
  3. And after @alvinhochun added the feature of pausing at the end, the concern about missing the end, is put to rest as well.
  4. Lastly: Most of the users prefer consistency, so this contributes to that preference.

regards

@discip discip requested a review from Ralim May 11, 2021 16:13
@Ralim Ralim merged commit d1916d0 into Ralim:master May 17, 2021
@discip discip deleted the patch-1 branch May 18, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants