-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translation_EN.json #966
Conversation
], | ||
"desc": "Advanced options" | ||
"desc": "Advanced settings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency reasons
Translations/translation_EN.json
Outdated
@@ -171,14 +171,14 @@ | |||
"Auto", | |||
"start" | |||
], | |||
"desc": "Starts the iron into soldering mode on power up <O=off | S=soldering | Z=sleep | R=sleep at room temperature>" | |||
"desc": "On power up <O=don't heat | S=heat up to soldering temp | Z=heat up to sleep temp and only heat up to soldering temp when moved | R=only heat up to soldering temp when moved>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is still not clear enough, maybe someone else will be able to find the right words.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about starting with "Behaviour on power up: " (or "behavior" if you prefer AmE)?
I think the description for "Z" is perhaps a bit too long. Can we just say "enter sleep mode" to imply "only heat up to soldering temp when moved"? But this wouldn't be as clear.
Translations/translation_EN.json
Outdated
@@ -297,14 +297,14 @@ | |||
"Power pulse", | |||
"delay" | |||
], | |||
"desc": "Delay before keep-awake pulse is triggered (x 2.5s)" | |||
"desc": "Delay before keep-awake pulse is triggered <x 2.5s>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convention I know of here is to use ()
rather than <>
but also not really bothered. Does anyone have an opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ralim
Good morning Sir.
I changed these, because in all the other descriptions <>
is used.
I myself would prefer ()
over <>
and I initially thought about replacing all <>
with ()
, but didn't dare to.
Or am I mixing up something here?
Are you referring to these 2 occurrences only (x 2.5s)
?
thanks
kind regards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good morning :)
I was referring to them as a whole. I'm also a bit "eh" and not worried really, so long as they all match I'm happier.
Truth told, I rarely look at the descriptions so I hadn't noticed the trend to <>.
Happy to merge as is, or go to (), your preference is fine by me here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opinion:
< > should be used then documenting combobox like selections.
( ) should be used then there is optional not necessary information about the setting like guidelines, recommendations.
User should not do extra math to know what value really means. However maybe in this case [ ] should be used to determine stepping coefficient and snippet could be placed to description beginning, instead of the end.
[x 2.5s] Delay before keep-awake pulse is triggered.
Every description should end with dot, so user knows that the will is the end of the message.
Anyways there should be ruling consistence in whole file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ralim
Sorry, but I did not want to open an extra issue on the following:
Could you please clarify, what this setting is meant for?
"desc": "Power source. Sets cutoff voltage. <DC 10V> <S 3.3V per cell, disable power limit>"
Especially the disable power limit
is confusing.
Or am I missing something here?
Thank you in advance.
Translations/translation_EN.json
Outdated
@@ -269,14 +269,14 @@ | |||
"Allow locking", | |||
"buttons" | |||
], | |||
"desc": "When soldering, long press both buttons, to lock them <D=disable | B=\"boost mode\" only | F=full locking>" | |||
"desc": "While soldering, press both buttons long to lock them <D=disable | B=boost mode only | F=full locking>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "When in soldering mode, hold down both buttons to toggle button locking"?
Translations/translation_EN.json
Outdated
@@ -171,14 +171,14 @@ | |||
"Auto", | |||
"start" | |||
], | |||
"desc": "Starts the iron into soldering mode on power up <O=off | S=soldering | Z=sleep | R=sleep at room temperature>" | |||
"desc": "On power up <O=don't heat | S=heat up to soldering temp | Z=heat up to sleep temp and only heat up to soldering temp when moved | R=only heat up to soldering temp when moved>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about starting with "Behaviour on power up: " (or "behavior" if you prefer AmE)?
I think the description for "Z" is perhaps a bit too long. Can we just say "enter sleep mode" to imply "only heat up to soldering temp when moved"? But this wouldn't be as clear.
Hopefully these changes are somewhat acceptable now. 😊
regards |
hopefully helpful changes