Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exhaustive CHAID #113

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Added exhaustive CHAID #113

merged 3 commits into from
Oct 30, 2020

Conversation

Rambatino
Copy link
Owner

@Rambatino Rambatino commented Oct 30, 2020

Run with --exhaustive flag e.g:

python -m CHAID tests/data/titanic.csv survived sex embarked --max-depth 4 --min-parent-node-size 2 --alpha-merge 0.5 --dependent-variable-type continuous --exhaustive

This feature comes from a request from #112 - to make an exhaustive selection of the choices.

@Rambatino
Copy link
Owner Author

Fixes #112

@Rambatino Rambatino mentioned this pull request Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #113 into master will decrease coverage by 0.22%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   93.13%   92.90%   -0.23%     
==========================================
  Files           8        8              
  Lines         626      634       +8     
==========================================
+ Hits          583      589       +6     
- Misses         43       45       +2     
Impacted Files Coverage Δ
CHAID/stats.py 96.51% <90.00%> (-1.08%) ⬇️
CHAID/invalid_split_reason.py 100.00% <100.00%> (ø)
CHAID/tree.py 96.80% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5737f4...0144829. Read the comment docs.

@Rambatino Rambatino merged commit 3d561d6 into master Oct 30, 2020
@Rambatino Rambatino deleted the exhaustive_chaid branch October 30, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant