Audio engine fixes #838
Merged
Audio engine fixes #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower 4 bits are read-only, and its attempting to duplicate what wSoundOutput already does
bc isn't in use during InitSound Moved a comment SOUND_CHANNEL_ON doesnt need to be reset before ChannelInit
...i think
Does not actually work. Writes are ignored since the dac is on
Only reloads as needed now to avoid turning off the dac Also doesn't bother writing rNR31 as its value is ignored anyway
Has the neat side effect of making duty cycle patterns visible in the music player
Removes some redundant commands and restores dummied out duty_cycle_pattern calls
Removes a few places mono/stereo take different code paths, and allows changing between them without restarting the music
nickjwilde
pushed a commit
to nickjwilde/polishedcrystal
that referenced
this pull request
Jul 7, 2023
* Remove useless rNR52 writes Lower 4 bits are read-only, and its attempting to duplicate what wSoundOutput already does * Misc changes bc isn't in use during InitSound Moved a comment SOUND_CHANNEL_ON doesnt need to be reset before ChannelInit * Don't count rest notes as noise hits * Fixes Rangi42#837 ...i think * Don't call ReloadWaveform from the music player Does not actually work. Writes are ignored since the dac is on * Change waveform loading for audio channel 3 Only reloads as needed now to avoid turning off the dac Also doesn't bother writing rNR31 as its value is ignored anyway * Combine DutyCycle and SFXDutyCycle Has the neat side effect of making duty cycle patterns visible in the music player * duty_cycle changes in hgss/ceruleancity Removes some redundant commands and restores dummied out duty_cycle_pattern calls * Apply mono/stereo option once when writing rNR51 Removes a few places mono/stereo take different code paths, and allows changing between them without restarting the music
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all stereo-dependant branches, engine is essentially stereo only, with stereo/mono mixing handled when writing rNR51. The options menu no longer restarts the music as the change applies instantly
Fixes #837 but i'm not entirely sure the fix is correct