Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix English typos #105

Merged
merged 3 commits into from
May 21, 2018
Merged

Fix English typos #105

merged 3 commits into from
May 21, 2018

Conversation

Madis0
Copy link
Contributor

@Madis0 Madis0 commented May 20, 2018

Edited directly on Gedit, hope I didn't change metadata

Edited directly on Gedit, hope I didn't change metadata
Compared to my translation, which didn't use \ to escape ', so removing it from here too.
@RaphaelRochet
Copy link
Owner

Thanks for pointing these.

Do you think "New updates' names" should be changed to "Names of new updates" ? Or something else ... I'm open on this ! ( same for "All updates' names" )

@Madis0
Copy link
Contributor Author

Madis0 commented May 21, 2018

Yeah, that would make sense.

  • Amount of updates
  • Names of new updates
  • Names of all updates

But I assume "the updates" are actually just package names, therefore:

  • Amount of updatable packages
  • New updatable packages
  • All updatable packages

Madis0 added a commit to Madis0/arch-update that referenced this pull request May 21, 2018
According to English changes in RaphaelRochet#105
Madis0 added a commit to Madis0/arch-update that referenced this pull request May 21, 2018
@RaphaelRochet
Copy link
Owner

Very good, I like this. Thanks !

@RaphaelRochet RaphaelRochet merged commit 5a54034 into RaphaelRochet:master May 21, 2018
RaphaelRochet pushed a commit that referenced this pull request May 21, 2018
@Madis0 Madis0 deleted the fix-en branch January 26, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants