Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations Improvements and add-missings for zh_CN #54

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

inkuxuan
Copy link
Contributor

@inkuxuan inkuxuan commented Nov 22, 2023

Hi. Thanks for this fantastic app.

This is a PR for Chinese Simplified translations.

Improves several expressions for "ONLY if sleep mode is enabled" rather than "If enabled". 
Adds several missing translations.

If being credited, would like to show up as "いんく".
Twitter @sayonara_natsu

<3

P.S. I've noticed that there are OyasumiVR Extra Translation Tasks remaining.
Would love to do zh_CN, zh_TW and ja_JP translations.
However I'm not sure where the achievement JSON files are located.

inkuxuan and others added 3 commits November 22, 2023 19:26
Improves several expressions for "ONLY if sleep mode is enabled" rather than "If enabled".
Adds several missing translations
@Raphiiko
Copy link
Owner

Raphiiko commented Nov 22, 2023

@inkuxuan Thank you for your contribution! ^^

I have updated your PR to add the appropriate credits. Before I merge this however, do you think you could update the credits in README_zh_CN.md (and maybe README_zh_TW.md too?), similar to how it was added to the other readme files? I am not familiar enough with these languages to know how to this properly.

As for the extra translation tasks, feel free to pick them up!

  • For the tasks affecting readme files, you can just open a separate PR for them.
  • Specifically for the ja_JP readme, I believe なき (our Japanese translator) is currently already working on updating it.
  • Achievements (currently) have no JSON file. The exact strings to translate are within the tasks on the board. If you translate them, you can submit them on our Discord Server, by sending me a DM (discord/twitter), or by submitting them in an issue here on GitHub, whichever way you prefer!

@Raphiiko
Copy link
Owner

Looking good!

@Raphiiko Raphiiko merged commit adffcda into Raphiiko:develop Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants