Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget Version Testing Add #52

Merged
merged 2 commits into from
May 5, 2024
Merged

Winget Version Testing Add #52

merged 2 commits into from
May 5, 2024

Conversation

JMacIV
Copy link
Contributor

@JMacIV JMacIV commented May 3, 2024

Added testing for version of winget when setting the "wingetInstalled" var. Updated output to reflect that the version of winget could be outdated.

Related to #51

Copy link
Owner

@Raphire Raphire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of warning users of issues with WinGet. It's not really within the scope of Win11Debloat to update it.

The current warning won't work though, I made a suggestion on how to improve it 😄

Win11Debloat.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Jeffrey <9938813+Raphire@users.noreply.github.com>
@JMacIV
Copy link
Contributor Author

JMacIV commented May 3, 2024

I like the idea of warning users of issues with WinGet. It's not really within the scope of Win11Debloat to update it.

The current warning won't work though, I made a suggestion on how to improve it 😄

Suggestion looks good. I have not tested your changes, but it looks good ha.

I figured you would not want to update it within debloat script. If you did decide to, you could always make it an optional opt-in prompt with a warning that it will either download from MS Store, or GitHub. I will prob maintain this code in my fork since I will want it to automatically install the winget upgrade for my purposes :)

@Raphire
Copy link
Owner

Raphire commented May 5, 2024

I figured you would not want to update it within debloat script. If you did decide to, you could always make it an optional opt-in prompt with a warning that it will either download from MS Store, or GitHub. I will prob maintain this code in my fork since I will want it to automatically install the winget upgrade for my purposes :)

I appreciate that for your purposes it's nice to have it install automatically, but I think the warning is enough. I don't really want the script to be responsible for updating stuff like this.

I suspect the next Windows image provided by MS will come with a more up-to-date WinGet version, so we won't run into this problem anymore.

@Raphire Raphire merged commit 136a5b1 into Raphire:master May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants