Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling for more convenient justify parameter passing #149

Merged
merged 2 commits into from
Mar 17, 2015

Conversation

Quiri
Copy link

@Quiri Quiri commented Feb 10, 2015

Added handling for more convenient justify parameter passing. So if user needs to justify multiple columns differently, it is more convenient to pass e.g. justify = "llcrr" instead of justify = c("left", "left", "centre", "right", "right"). This is Latex style.

@daroczig
Copy link
Member

Wow, this is great! Thanks for the idea and implementation as well. Can you please also add some test cases (via testthat in the inst/tests folder) and update the documentation with this new feature (in the Roxygen tags of pandoc.table)? I would be even happier to merge those as well :)

@Quiri
Copy link
Author

Quiri commented Feb 23, 2015

I'm glad you like it, I'll update the rest as you requested and commit that as well.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 816241d on Quiri:master into * on Rapporter:master*.

daroczig added a commit that referenced this pull request Mar 17, 2015
Added handling for more convenient justify parameter passing
@daroczig daroczig merged commit f69fe62 into Rapporter:master Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants