-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ets class objects #231
Conversation
Added support for ets class objects
Added support for ets class objects
@@ -41,6 +41,7 @@ New classes supported by the `pander` generic S3 method: | |||
* lrm | |||
* summary.rms | |||
* polr/summary.polr | |||
* ets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this into separate category, since technically this change is not in pander 0.6
Thanks for the PR! In general, great job, just few minor style comments (inlined). Also to fix the failing test, you need to abb |
NEWS and styling fixes, added forecast to DESCRIPTION.
Thanks for the feedback, I've made some changes. Checking output of tests, may have miscounted. |
Current coverage is
|
@mitchelloharawild, thank you very much for the pull request & fixed, and thanks for @RomanTsegelskyi for the comments. I generally like the output, but not sure if all parts are important -- can you please share your opinion on that? First, we return the And maybe we could add a dollar sign around the What do you think? |
As I did not hear from you about the above questions, I suppose everything is all right and should remain as is :) Thank you both, again! Merging. |
Support for ets class objects
Added support for ets class objects