Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cran fix #325

Closed
wants to merge 2 commits into from
Closed

Cran fix #325

wants to merge 2 commits into from

Conversation

MaximeWack
Copy link

Hi,

Here is the implementation of the proposed fix in #324 (comment)

author and title are tested for any non-empty string, then sanitized to remove all empty strings in the vectors.

@MaximeWack MaximeWack mentioned this pull request Jul 6, 2018
Closed
@daroczig daroczig closed this in 54c77b4 Jul 7, 2018
@daroczig
Copy link
Member

daroczig commented Jul 7, 2018

Thanks a lot 👍

@MaximeWack MaximeWack deleted the cran_fix branch July 7, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximeWack @daroczig