Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ButtonStyle.premium #9845

Merged
merged 9 commits into from
Jun 1, 2024
Merged

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented May 25, 2024

Summary

DDevs Docs PR: discord/discord-api-docs#6875

Removes InteractionResponse.require_premium in favor of ButtonStyle.premium like button components.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@AbstractUmbra
Copy link
Contributor

This is not a breaking change, for what it's worth.

No contract has been broken since .require_premium never made it to a published release. I would argue that this checkbox could be removed from this PR.
Breaking changes do not happen between major version releases - if this is actually a breaking change, it will need to wait until 3.x!

discord/enums.py Outdated Show resolved Hide resolved
discord/ui/button.py Show resolved Hide resolved
docs/interactions/api.rst Outdated Show resolved Hide resolved
docs/interactions/api.rst Show resolved Hide resolved
discord/ui/button.py Outdated Show resolved Hide resolved
discord/components.py Show resolved Hide resolved
@Rapptz Rapptz merged commit 356474f into Rapptz:master Jun 1, 2024
8 checks passed
@DA-344 DA-344 deleted the premium_interaction_response branch July 22, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants