Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about contexts and installation_types only being available for global commands #9846

Merged
merged 4 commits into from
May 31, 2024

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented May 26, 2024

Summary

While in preview, only global commands can be made into user installable apps and I think the docs should note that on the guild(s) decorator and kwargs.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording is fine, but can you expand "kwarg" to "keyword argument" in the documentation.

@Soheab Soheab requested a review from Rapptz May 30, 2024 16:53
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rapptz Rapptz merged commit cc32fb3 into Rapptz:master May 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants