Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes everything build with VC++ and also adds a void overload for sol::function. #8

Merged
merged 6 commits into from
Dec 14, 2013

Conversation

ThePhD
Copy link
Contributor

@ThePhD ThePhD commented Dec 14, 2013

No description provided.

@@ -120,6 +123,7 @@ int plop_xyz(int x, int y, std::string z) {
lua.set_function("g", [ ] { return std::string("str"); });
lua.set_function("h", [ ] { });
lua.set_function("i", [ ] { return sol::nil; });
//lua.set_function("i", [ ] { return std::make_tuple(1, 6.28f, 3.14, std::string("heh")); });
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you comment this out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just messing around. VC++ can't compile this line: error C4789: buffer '' of size 4 bytes will be overrun; 1 bytes will be written starting at offset 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to find a way to make it work, i guess, but the error message (as you can see) is uber cryptic.

… Table` was taken by reference... oh well. It's fixed now. I wish VC++ didn't choke so badly on decltype.
…ng out by explicitly declaring the size of the `swallow` declaration. This should make all compilers happy.
@ThePhD
Copy link
Contributor Author

ThePhD commented Dec 14, 2013

So solved the swallow problem (I believe), and I think I'll remove the extra operator() functions on sol::function, just to keep the API clean...

Rapptz added a commit that referenced this pull request Dec 14, 2013
Makes everything build with VC++ and also adds a void overload for `sol::function`.
@Rapptz Rapptz merged commit bec0406 into Rapptz:master Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants