-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ENS support for address reverse resolution and avatar #470
Conversation
hey thanks for your contribution, but we're not comfortable merging this with such a huge package-lock diff, as you could be installing a malicious npm package somewhere in there... if you'd like to revise this PR to have a more minimal package-lock diff that we can certify is safe, we'd be happy to merge this :) |
hey @transmissions11 , yeah that makes total sense. All I did was to include the |
dw fren i trust you, but with all the frontend exploits going around recently we've gotta vet this stuff nonetheless 😅 as for why the diff is so large, i'd guess you're using an older version of NPM which uses a different package-lock format. try installing the version listed in the requirements README section. |
@frimoldi is attempting to deploy a commit to the Rari Capital Team on Vercel. A member of the Team first needs to authorize it. |
@transmissions11 I've regenerated |
Pull Request Test Coverage Report for Build 1550235526
💛 - Coveralls |
ENS reverse resolution
By adding ENS reverse resolution, the
AccountButton
component now is able to display the ENS name and avatar image, instead of the Ethereum address.Changes
@ensdomains/ensjs
dependency to handle ENS reverse resolution (eth address => ens name).Avatar
shared component. this component will display the ENS avatar image if there's any, orJazzicon
otherwise.RariContext
to provide the resolved ENS name.