Merge pull request #5366 from DomAmato/bugfix/fallback

Fix bug where Fallback Policy always falls back when fallback action is action listen
RasaHQ · Mar 16, 2020 · 807d9b0 · 807d9b0
2 parents 3a49f2a + 71be250
commit 807d9b0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/changelog/5356.bugfix.rst b/changelog/5356.bugfix.rst
@@ -0,0 +1,2 @@
+Fixed bug where ``FallbackPolicy`` would always fall back if the fallback action is
+``action_listen``.
diff --git a/rasa/core/policies/fallback.py b/rasa/core/policies/fallback.py
@@ -144,7 +144,15 @@ def predict_action_probabilities(
 
         nlu_data = tracker.latest_message.parse_data
 
-        if tracker.latest_action_name == self.fallback_action_name:
+        if (
+            tracker.latest_action_name == self.fallback_action_name
+            and tracker.latest_action_name != ACTION_LISTEN_NAME
+        ):
+            logger.debug(
+                "Predicted 'action_listen' after fallback action '{}'".format(
+                    self.fallback_action_name
+                )
+            )
             result = self._default_predictions(domain)
             idx = domain.index_for_action(ACTION_LISTEN_NAME)
             result[idx] = 1.0