-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python36 and security updates #11052
Drop python36 and security updates #11052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything good with the PR in itself, but before merging this we should answer the open questions around how we exactly want to release this.
the pr doesn't include updates for tf / pillow - are they in a separate pr or am i missing something? |
@tmbo |
ah yes that makes sense, sorry I missed that 👍 |
@joejuzl @losterloh are we confident that the redis major version changes is sufficiently tested with our functional / integration tests or do we need to do a manual QA step? |
@m-vdb I don't think I can answer that question with my current level of knowledge, I'd need to invest some time to look at the integration test suite for that. (Of course, happy to do that if this is now a high priority). |
sounds good @losterloh -- I don't expect you to get this answer since you just joined Atom last week. I've taken the habit of @-mentioning you and Joe 😅 |
@m-vdb the integration tests only test redis with the lock store, so I would say to be safe a QA pass makes sense. |
Proposed changes:
Fixes https://rasahq.atlassian.net/browse/SB-66