Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add testing story example for button with payload #11766

Merged
merged 4 commits into from
Nov 18, 2022
Merged

doc: add testing story example for button with payload #11766

merged 4 commits into from
Nov 18, 2022

Conversation

porti20
Copy link
Contributor

@porti20 porti20 commented Nov 16, 2022 •
edited
Loading

Proposed changes:

  • Clearify in the documentation how to write testing stories if a user press a button with payload

Status (please check what you already did):

  • updated the documentation
  • updated the changelog (please check changelog for instructions)

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ancalita ancalita self-requested a review November 17, 2022 14:54
ancalita
ancalita requested changes Nov 18, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@porti20 Thank you for contribution 💯 Left two suggestions which should be addressed for approval.

changelog/11766.doc.md Outdated Show resolved Hide resolved
docs/docs/testing-your-assistant.mdx Outdated Show resolved Hide resolved
porti20 and others added 2 commits November 18, 2022 11:40
@porti20 @ancalita
Fix spelling in changelog/11766.doc.md
279c936 
Co-authored-by: Anca Lita <27920906+ancalita@users.noreply.github.com>
@porti20 @ancalita
fix button example highlight line in docs/docs/testing-your-assistant…
caa91c8 
….mdx

Co-authored-by: Anca Lita <27920906+ancalita@users.noreply.github.com>
@porti20
Copy link
Contributor Author

porti20 commented Nov 18, 2022

@ancalita Thanks for your review, i accepted you changes :)

ancalita
ancalita approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ancalita ancalita merged commit 89671f0 into RasaHQ:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@porti20 @CLAassistant @ancalita