Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow intents as list in from_intent in slot mapping #12268

Merged
merged 7 commits into from
Apr 13, 2023
Merged

Allow intents as list in from_intent in slot mapping #12268

merged 7 commits into from
Apr 13, 2023

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Apr 11, 2023 •
edited by jira bot
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt requested a review from a team as a code owner April 11, 2023 15:37
@Tawakalt Tawakalt removed the request for review from a team April 11, 2023 15:52
@Tawakalt Tawakalt force-pushed the ATO-919-define-intent-as-list-in-from-intent-sm-3.5.x branch from d7cf24e to 4c4a7c9 Compare April 11, 2023 15:56
@Tawakalt Tawakalt requested a review from ancalita April 12, 2023 07:18
ancalita
ancalita reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
Left some questions about the unit test, I'd also say separate the unit test into 2 (one that tests valid test cases and another one that tests invalid mappings to ease the cognitive load when reading tests).

tests/shared/core/test_slot_mappings.py Show resolved Hide resolved
tests/shared/core/test_slot_mappings.py Outdated Show resolved Hide resolved
@Tawakalt Tawakalt requested a review from ancalita April 13, 2023 13:18
@Tawakalt Tawakalt requested a review from ancalita April 13, 2023 13:31
@Tawakalt Tawakalt force-pushed the ATO-919-define-intent-as-list-in-from-intent-sm-3.5.x branch from ccd24b4 to 0a8c3fb Compare April 13, 2023 13:34
ancalita
ancalita approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Tawakalt Tawakalt enabled auto-merge April 13, 2023 13:52
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12268--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@Tawakalt Tawakalt merged commit 21bbac1 into 3.5.x Apr 13, 2023
@Tawakalt Tawakalt deleted the ATO-919-define-intent-as-list-in-from-intent-sm-3.5.x branch April 13, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tawakalt @ancalita