Fix duplicate interactive learning events #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
force-pushed
the
fix-duplicate-interactive-learning-events
branch
2 times, most recently
from
7c1ff86
to
18524d7
Compare
wochinge
force-pushed
the
fix-duplicate-interactive-learning-events
branch
from
18524d7
to
92d9428
Compare
tabergma
approved these changes
Jun 7, 2019
rasa/core/training/interactive.py
Outdated
| @@ -424,6 +416,7 @@ def _selection_choices_from_intent_prediction( | |||
| choices, sender_id, endpoint | |||
| ) | |||
|
|
|||
| # TODO: Should we not always set the confidence = 1.0? | |||
There was a problem hiding this comment.
Which scenarios do you mean? The scenario in which the user selected a specific intent? Maybe, something to discuss in Slack?
There was a problem hiding this comment.
Discussed it with Akela, and we now set it to 1.0
tabergma
reviewed
Jun 7, 2019
|
implemented the review comments 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
finetuningstuff since it's not longer supportedStatus (please check what you already did):
black(please check Readme for instructions)