Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix twostage il #4100

Merged
merged 4 commits into from
Jul 25, 2019
Merged

Fix twostage il #4100

merged 4 commits into from
Jul 25, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jul 24, 2019 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge mentioned this pull request Jul 25, 2019
Closed
erohmensing
erohmensing approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe this one line caused that guy (and you) so much grief, haha. Thanks for pinning it down!

@wochinge wochinge mentioned this pull request Jul 25, 2019
Merged
5 tasks
@wochinge wochinge merged commit e44270a into master Jul 25, 2019
@wochinge wochinge deleted the fix-twostage-il branch July 25, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two stage fallback policy slots
2 participants
@wochinge @erohmensing