-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event_broker param to custom tracker #4593
Conversation
Like other store types, custom tracker needs event_broker to stream events.
Custom tracker accepts optional event_broker parameter which needs to be reflected in ExampleTrackerStore
Thanks for the PR, we'll give it a review as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Your change makes the code more consistent and useful 🚀
One more thing left before we can merge this: Can you please update the changelog? Should be a line in the section Changed
Changelog updated with change for adding event_broker param to custom tracker store
Thanks , I have updated the changelog |
Thanks, I have updated the changelog with the suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work in adding that and making things more consistent! Thanks a lot 🙏
@AppliedSoul Github seems to be weird - did you already accept the |
@wochinge I had already accepted cla , seems like cla-assistant/cla-assistant#124 , else I could push another commit to trigger rechecks. |
@AppliedSoul Merged 🎉 Thanks for linking the issue, too, rechecking the CLAs fixed it. |
Like other store types, custom tracker needs event_broker to stream events.
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)