Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event_broker param to custom tracker #4593

Merged
merged 5 commits into from
Oct 16, 2019

Conversation

AppliedSoul
Copy link
Contributor

@AppliedSoul AppliedSoul commented Oct 10, 2019

Like other store types, custom tracker needs event_broker to stream events.

Proposed changes:

  • Add event_broker parameter to custom tracker

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

Like other store types, custom tracker needs event_broker to stream 
events.
Custom tracker accepts optional event_broker parameter which needs to be 
reflected in ExampleTrackerStore
@msamogh
Copy link
Contributor

msamogh commented Oct 14, 2019

Thanks for the PR, we'll give it a review as soon as possible.

@msamogh msamogh requested a review from wochinge October 14, 2019 09:26
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Your change makes the code more consistent and useful 🚀
One more thing left before we can merge this: Can you please update the changelog? Should be a line in the section Changed

Changelog updated with change for adding event_broker param to custom 
tracker store
@AppliedSoul
Copy link
Contributor Author

Thanks , I have updated the changelog

CHANGELOG.rst Outdated Show resolved Hide resolved
@AppliedSoul
Copy link
Contributor Author

Thanks, I have updated the changelog with the suggestion.

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work in adding that and making things more consistent! Thanks a lot 🙏

@wochinge
Copy link
Contributor

@AppliedSoul Github seems to be weird - did you already accept the cla?

@AppliedSoul
Copy link
Contributor Author

@wochinge I had already accepted cla , seems like cla-assistant/cla-assistant#124 , else I could push another commit to trigger rechecks.

@wochinge wochinge merged commit 5c81fe2 into RasaHQ:master Oct 16, 2019
@wochinge
Copy link
Contributor

@AppliedSoul Merged 🎉 Thanks for linking the issue, too, rechecking the CLAs fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom tracker store should be passed with optional event_broker instance
3 participants