Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note in pretrained_embeddings_convert section - 1.5.x #4930

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

AndrewKinsman
Copy link
Contributor

@dakshvar22 Re: Update note in pretrained_embeddings_convert section #4920

Proposed changes:

I believe it is tensorflow-text and tensorflow-hub rather than tensorflow_text and tensorflow_hub (although apparently these should resolve to the same packages anyhow).
Unfortunately, I don't think you can install tensorflow-text on Windows or other non-Linux platforms.

Status (please check what you already did):

  • added some tests for the functionality
  • [* ] updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@dakshvar22 dakshvar22 merged commit 68d5d4e into RasaHQ:1.5.x Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants