Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build docker containers as part of our continuous integration workflow #5330

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Build docker containers as part of our continuous integration workflow #5330

merged 1 commit into from
Mar 3, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Feb 27, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo force-pushed the build-docker branch 3 times, most recently from 8a5203b to bc7bd48 Compare March 2, 2020 17:35
@tmbo tmbo changed the title build containers in gh Build docker containers as part of our continuous integration workflow Mar 2, 2020
@tmbo tmbo marked this pull request as ready for review March 2, 2020 17:44
@tmbo tmbo requested a review from wochinge March 2, 2020 17:44
wochinge
wochinge approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.github/workflows/continous-integration.yml Show resolved Hide resolved
.github/workflows/continous-integration.yml Show resolved Hide resolved
.github/workflows/continous-integration.yml Show resolved Hide resolved
@tmbo tmbo changed the base branch from master to 1.8.x March 3, 2020 10:39
@tmbo tmbo merged commit 30285a6 into 1.8.x Mar 3, 2020
@tmbo tmbo deleted the build-docker branch March 3, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build docker containers as a step of CI pipeline
2 participants
@tmbo @wochinge